Skip to content

Refactoring - #634

Merged
NeptuneHub merged 14 commits into
mainfrom
devel
Jun 12, 2026
Merged

Refactoring#634
NeptuneHub merged 14 commits into
mainfrom
devel

Conversation

@NeptuneHub

@NeptuneHub NeptuneHub commented Jun 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Owner

This PR contain different code refactoring like:

  • move all the mediaserver file in /task/mediaserver
  • move all the test in /test/integration /test/unit
  • move all the native build folder under /native-build
  • remove unused file, function, variable and use centralized function when duplicated.

PR test builds:

@NeptuneHub @claude
test refactoring
4d30fbf 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the test suite by separating tests into unit and integration subdirectories, updating test paths, configurations, and mock targets accordingly. It also removes the python-mpd2 dependency and cleans up references to the deprecated MPD backend. A high-severity issue was identified in test/unit/test_index_rebuild_integration.py where tasks.artist_gmm_manager is not imported within the try...except block guarding the integration tests. This could cause import errors to propagate and fail the test suite instead of cleanly skipping them when dependencies like voyager or sklearn are missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread test/unit/test_index_rebuild_integration.py
NeptuneHub and others added 7 commits June 12, 2026 15:44
@NeptuneHub @claude
Refactor complex import to reduce internal import
61986cf 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NeptuneHub @claude
Move native build directories under /native-build
31ab12f 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NeptuneHub @claude
Restore executable bits lost in the native-build move
d53e8f0 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NeptuneHub @claude
Move native build directory
8b7cfc1 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NeptuneHub
Code cleaning
456fedb
@NeptuneHub
Centralize and remove duplicated functionality
1e4b9a3
@NeptuneHub
sonarcloud review fix
d1201d5
@sonarqubecloud

sonarqubecloud Bot commented Jun 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

@NeptuneHub NeptuneHub mentioned this pull request Jun 12, 2026
Closed
@NeptuneHub
NeptuneHub merged commit 21a3f9c into main Jun 12, 2026
23 checks passed
@NeptuneHub
NeptuneHub deleted the devel branch June 12, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NeptuneHub